1234567 - (too-bad-this-was-not-an-awesome-bug) Intermittent browser_animation_controller_exposes_document_currentTime.js | Test timed out - | Cleanup function threw an exception - at resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/client/framework/toolbox.js:1916 - TypeError:

Status: NEW

(DevTools :: Inspector: Animations, defect, P3)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

On Linux opt https://treeherder.mozilla.org/logviewer.html#?job_id=6299723&repo=fx-team

06:38:29     INFO -  20 INFO TEST-START | devtools/client/animationinspector/test/browser_animation_controller_exposes_document_currentTime.js
06:39:27     INFO -  TEST-INFO | started process screentopng
06:39:30     INFO -  TEST-INFO | screentopng: exit 0
06:39:30     INFO -  21 INFO checking window state
06:39:30     INFO -  22 INFO Entering test
06:39:30     INFO -  23 INFO Adding a new tab with URL: 'http://example.com/browser/devtools/client/animationinspector/test/doc_simple_animation.html'
06:39:30     INFO -  24 INFO Loading the helper frame script chrome://mochitests/content/browser/devtools/client/animationinspector/test/doc_frame_script.js
06:39:30     INFO -  25 INFO Loading the helper frame script chrome://devtools/content/shared/frame-script-utils.js
06:39:30     INFO -  26 INFO URL 'http://example.com/browser/devtools/client/animationinspector/test/doc_simple_animation.html' loading complete
06:39:30     INFO -  27 INFO Opening the toolbox with the inspector selected
06:39:30     INFO -  28 INFO TEST-UNEXPECTED-FAIL | devtools/client/animationinspector/test/browser_animation_controller_exposes_document_currentTime.js | Test timed out -
06:39:30     INFO -  *************************
06:39:30     INFO -  A coding exception was thrown and uncaught in a Task.
06:39:30     INFO -  Full message: TypeError: this.closeButton is undefined
06:39:30     INFO -  Full stack: Toolbox.prototype.destroy@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/client/framework/toolbox.js:1916:5
06:39:30     INFO -  DT_closeToolbox@resource://devtools/client/framework/gDevTools.jsm:464:12
06:39:30     INFO -  closeAnimationInspector<@chrome://mochitests/content/browser/devtools/client/animationinspector/test/head.js:226:9
06:39:30     INFO -  @chrome://mochitests/content/browser/devtools/client/animationinspector/test/head.js:27:9
06:39:30     INFO -  TaskImpl_run@resource://gre/modules/Task.jsm:315:40
06:39:30     INFO -  TaskImpl@resource://gre/modules/Task.jsm:276:3
06:39:30     INFO -  createAsyncFunction/asyncFunction@resource://gre/modules/Task.jsm:250:14
06:39:30     INFO -  Task_spawn@resource://gre/modules/Task.jsm:164:12
06:39:30     INFO -  TaskImpl_handleResultValue@resource://gre/modules/Task.jsm:384:1
06:39:30     INFO -  TaskImpl_run@resource://gre/modules/Task.jsm:323:13
06:39:30     INFO -  TaskImpl@resource://gre/modules/Task.jsm:276:3
06:39:30     INFO -  createAsyncFunction/asyncFunction@resource://gre/modules/Task.jsm:250:14
06:39:30     INFO -  timeoutFn@chrome://mochikit/content/browser-test.js:848:9
06:39:30     INFO -  setTimeout handler*Tester_execTest@chrome://mochikit/content/browser-test.js:810:9
06:39:30     INFO -  Tester.prototype.nextTest</<@chrome://mochikit/content/browser-test.js:676:7
06:39:30     INFO -  SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:735:59

Comment 1

[Randell Jesup [:jesup] (needinfo me)]

Too bad this wasn't an awesome bug..

Comment 2

[Dão Gottwald [:dao]]

I'm going to disable this test on Linux.

Comment 3

[Ryan Feeley [:rfeeley]]

’Dat bug number :)

Comment 4

[Patrick Brosset <:pbro>]

Triaging (filter on CLIMBING SHOES).

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2fffb44333de
disable test_notificationbox.xul for frequent failures on windows and linux. r=jmaher

Comment 6

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3e21fcc6243e
Backed out changeset 2fffb44333de for landing with the incorrect bug number

Comment 7

[Necko Bot]

A log has been successfully uploaded to the team's storage

Comment 8

[Luke Crouch [:groovecoder]]

Attachment: Bug 1234567: fix(passwordmgr,Relay): Ensure Firefox Relay item shows up for signed-in users regardless of site allow-list status. r?#credential-management-reviewers

• Adjusted RelayOffered logic to ensure Relay is shown only if the user is signed in or if the showToAllBrowsersPref is enabled, combined with allow-list checks.
• Added a new test (test_site_not_on_allowList_still_shows_Relay_to_signed_in_browser) to verify behavior.

Comment 9

[Phabricator Automation]

Comment on attachment 9438849 [details]
Bug 1234567: fix(passwordmgr,Relay): Ensure Firefox Relay item shows up for signed-in users regardless of site allow-list status. r?#credential-management-reviewers

Revision D229640 was moved to bug 1932414. Setting attachment 9438849 [details] to obsolete.